atenet: add agentgateway egress support - #909
Open
Eitan Yarmush (EItanya) wants to merge 1 commit into
Open
Conversation
Collaborator
|
looking at this today! |
Lior Lieberman (LiorLieberman)
left a comment
Lior Lieberman (LiorLieberman)
left a comment
Collaborator
There was a problem hiding this comment.
LGTM overall. left a few comments.
| ) | ||
|
|
||
| const ( | ||
| // ClientCertificateAttribute is the PEM peer certificate agentgateway |
Collaborator
There was a problem hiding this comment.
is this only relevant for agentgateway?
If yes, maybe you call that agentgatewayClientCertificateAttribute?
Collaborator
There was a problem hiding this comment.
also is this dynamic metadata? just curios how you compare that vs the forwarded Client Cert Header ?
|
|
||
| const ( | ||
| // DirectionAttribute is set from a dataplane expression, not a client | ||
| // header, by dataplanes without Envoy filter chains. |
Collaborator
There was a problem hiding this comment.
by dataplanes without Envoy filter chains.
who sets this request attribute, agw? Also I think we probably want some more specific namespace like ate.calllout(maybe a better key name?).direction
| echo " --delete-all Delete core system and all registered demos" | ||
| echo " --ateapi-client-auth=cert|token Select how in-cluster clients authenticate to ateapi for --deploy-ate-system (default: cert; the server always accepts both)" | ||
| echo " --atenet-router=envoy|agentgateway Select the atenet router dataplane (default: envoy)" | ||
| echo " --atenet-router=envoy|agentgateway Select the ingress and egress dataplane (default: envoy)" |
Collaborator
There was a problem hiding this comment.
hmmm dont we want separate flags for that..? atenet-egress|atenet-ingress?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add agentgateway support to the actor egress gateway.
--atenet-router=agentgatewaynow selectsagentgateway for both ingress and egress, while Envoy remains the default.
What changed
ext_prochandlerIP:portsource.certificatetoext_proc.