feat(examples): use Chinese ecommerce agent names - #262
Conversation
ralf0131
left a comment
There was a problem hiding this comment.
LGTM. Clean, focused change — introduces named constants for the Chinese agent display names (售前服务 / 售后服务) and keeps the English identifiers stable. Documentation updates in both READMEs accurately describe the expected trace span names. Tests properly reference the constants instead of hardcoded strings.
Automated review by github-manager-bot
ralf0131
left a comment
There was a problem hiding this comment.
LGTM. Trivial change, well-tested (10 tests pass), documentation updated in both EN and ZH. Good use of named constants for maintainability.
Automated review by github-manager-bot
|
This PR has been automatically marked as stale because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 days of this comment. |
Description
This is a follow-up to #260. It changes the two ecommerce customer-service agent display names from English to Chinese so that traces for Chinese users show:
invoke_agent 售前服务invoke_agent 售后服务The LangGraph node names, Python identifiers, route values, and tool names remain in English to keep the implementation stable and easy to maintain.
The English and Chinese READMEs now document the expected trace names.
Fixes # (N/A)
Type of change
How Has This Been Tested?
cd examples/ecommerce-customer-service && uv run --isolated --no-project --with-requirements requirements.txt --with-requirements requirements-dev.txt python -m pytest tests -q(10 passed)tox -e precommitinvoke_agentspan names andgen_ai.agent.namevaluesValidation Evidence
invokeworkflowDoes This PR Require a Core Repo Change?
Checklist:
The PR should carry the
Skip Changeloglabel because it only adjusts an example's user-facing agent names and documentation.