Skip to content

verify_tools: update golang crypto mod to v.0.14.0#9

Merged
billy-lau merged 1 commit into
android:mainfrom
billy-lau:verifier_tools/bump-crypto-version
Jun 26, 2026
Merged

verify_tools: update golang crypto mod to v.0.14.0#9
billy-lau merged 1 commit into
android:mainfrom
billy-lau:verifier_tools/bump-crypto-version

Conversation

@billy-lau

Copy link
Copy Markdown
Member

Tests: all test pass.

Change-Id: Ia3dae790f37ff352635215fd257447f9b65424b3

Tests: all test pass.

Change-Id: Ia3dae790f37ff352635215fd257447f9b65424b3
@billy-lau billy-lau merged commit 404771e into android:main Jun 26, 2026
7 checks passed

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the 'golang.org/x/crypto' dependency to version 'v0.14.0' and cleans up 'go.sum'. However, this new dependency version requires Go 1.18 or later, while 'go.mod' currently specifies Go 1.17. The Go directive in 'go.mod' should be updated to at least '1.18' (or '1.21' if 'log/slog' is imported) to avoid build or compatibility issues.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

)

require golang.org/x/crypto v0.0.0-20191011191535-87dc89f01550 // indirect
require golang.org/x/crypto v0.14.0 // indirect

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The update to 'golang.org/x/crypto v0.14.0' requires Go 1.18 or later. However, the 'go.mod' file currently specifies 'go 1.17'. To prevent potential build or compatibility issues, the 'go' directive in 'go.mod' should be updated to at least '1.18' (or '1.21' since 'log/slog' is imported in 'verifier.go').

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant