test(@angular/cli): verify package group locking under peer updates#33549
Merged
Conversation
Asserts that the update resolver loops correctly prioritize package group expansions before evaluating peer dependencies. This prevents regression of issue angular#22654, where specifying a package with a wide pre-release peer range (like @angular/cdk) before a package defining a group (like @angular/core) would resolve group dependencies (like @angular/common) to next-major pre-releases instead of locking them to target group versions.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds mock package definitions and a new unit test to update-resolver_spec.ts to verify that packageGroup versions are correctly maintained when updating packages alongside peer dependencies. There are no review comments, so no additional feedback is provided.
clydin
added
the
action: review
alan-agius4
approved these changes
Jul 10, 2026
alan-agius4
added
action: merge
Member
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Asserts that the update resolver loops correctly prioritize package group expansions before evaluating peer dependencies.
This prevents regression of issue #22654, where specifying a package with a wide pre-release peer range (like @angular/cdk) before a package defining a group (like @angular/core) would resolve group dependencies (like @angular/common) to next-major pre-releases instead of locking them to target group versions.