fix(@angular/build): add splitting option to unit-test builder - #33961
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new splitting option (defaulting to true) to the unit-test builder schema for the Vitest runner. This option allows users to enable or disable code splitting for test execution, which can help resolve issues with live ESM bindings in Node.js environments. The Vitest build options have been updated to respect this configuration, and comprehensive unit tests have been added to verify the behavior of the splitting option. There are no review comments, and I have no additional feedback to provide.
alan-agius4
added
action: review
clydin
approved these changes
Aug 28, 2026
alan-agius4
added
action: merge
1 task
Adds a `splitting` option to the unit-test builder to control code splitting for the test build with the Vitest runner. This option is enabled by default to optimize test bundling performance and memory consumption, avoiding issues during code coverage collection. For Node-based test environments where live ESM bindings across chunk boundaries cause issues (such as uninitialized exports or mocking failures), splitting can be disabled. Closes angular#33960 and closes angular#33948
alan-agius4
force-pushed
the
fix-unit-test-splitting
branch
from
August 28, 2026 14:53
8515226 to
0e23fea
Compare
Collaborator
Author
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
splittingoption to the unit-test builder to control code splitting for the test build with the Vitest runner. This option is enabled by default to optimize test bundling performance and memory consumption, avoiding issues during code coverage collection. For Node-based test environments where live ESM bindings across chunk boundaries cause issues (such as uninitialized exports or mocking failures), splitting can be disabled.Closes #33960 and closes #33948