UI support for the scaleSystemVm API - #13321
Conversation
|
@bernardodemarco a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13321 +/- ##
============================================
- Coverage 18.10% 18.10% -0.01%
Complexity 16752 16752
============================================
Files 6037 6037
Lines 542796 542796
Branches 66456 66456
============================================
- Hits 98291 98283 -8
- Misses 433460 433467 +7
- Partials 11045 11046 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@gruckbit a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
| message: 'message.confirm.scale.up.system.vm', | ||
| dataView: true, | ||
| show: (record) => { return record.state === 'Running' && record.hypervisor === 'VMware' || record.state === 'Stopped' }, | ||
| show: (record) => { return record.state === 'Running' && (record.hypervisor === 'VMware' || record.hypervisor === 'KVM') || record.state === 'Stopped' }, |
There was a problem hiding this comment.
Nit: mixing &&/|| without parens around the whole expression is a bit hard to scan, even though the added parens around the hypervisor check are correct. Wrapping the full condition in parens would make the intent clearer at a glance.
Description
ACS has the
scaleSystemVmAPI that allows scaling system VMs. However, currently the API is not accessible through the graphical interface for KVM. Thus, the graphical interface has been extended to allow the execution of this API.Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Screenshots (if appropriate):
How Has This Been Tested?
The global setting
enable.dynamic.scale.vmwas set to True, then the system VM template'sDynamically scalableoption was also set to True. Finally, new system offerings were registered to verify the form's listing behavior, showing only offers greater than or equal to the current offer. Lastly, the service offering change was performed both for running and stopped VMs.Before:
After: