fix: support pycapsule methods with arguments - #1675
Open
BharatDeva wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1669.
Rationale for this change
register_table_factoryaccepts FFI table-provider-factory exporters whose__datafusion_table_provider_factory__method needs the logical extension codec capsule as an argument. The sharedfrom_pycapsule!helper only supported zero-argument dunder methods, so this call site had to keep its own PyCapsule decoding logic.What changes are included in this PR?
This adds an argument-aware arm to
from_pycapsule!and uses it to exposetable_provider_factory_from_pycapsule.SessionContext.register_table_factorynow uses that shared helper for raw table-provider-factory capsules and exportable objects, while keeping the existing Python-wrapper path for plain Python table factories.Are there any user-facing changes?
No API change is intended. This is an internal cleanup that lets the existing FFI table-provider-factory path use the same capsule validation/conversion helper as the other FFI capsule paths.
Testing
cargo fmt --checkgit diff --checkwsl bash -lc "cd /mnt/c/Users/bhara/OneDrive/Desktop/Python/datafusion-python && cargo check -p datafusion-python"wsl bash -lc "cd /mnt/c/Users/bhara/OneDrive/Desktop/Python/datafusion-python && cargo test -p datafusion-python-util"