[server] Clarify remote log start offset semantics - #3942
Closed
gyang94 wants to merge 1 commit into
Closed
Conversation
Keep manifest-visible start offsets logical and distinguish physical segment start offsets throughout the remote log call chain. Co-Authored-By: Codex <noreply@openai.com> AI-Model: gpt-5 AI-Contributed/Feature: 200/200 AI-Contributed/UT: 118/118
2 tasks
gyang94
marked this pull request as ready for review
August 11, 2026 08:17
Member
|
Continue with #3956 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Close #3943.
Keep the remote log start offset reported by the manifest and tablet aligned with the manifest-visible logical range. A replacement object may physically start before the current visible range; for example, a physical object covering
[5, 25)can be visible only from offset10. Reporting physical offset5would incorrectly expose an expired prefix.Brief change log
RemoteLogManifestphysicalStartOffsetTests
mvn -o -pl fluss-common -DskipITs -Dfast -Dtest=RemoteLogManifestOverlapTest testmvn -o -pl fluss-server -am -DskipITs -Dfast -Dtest=RemoteLogTabletOverlapTest,RemoteLogTabletTest,RemoteLogManagerTest -Dsurefire.failIfNoSpecifiedTests=false testmvn -o -pl fluss-client,fluss-server,fluss-flink/fluss-flink-common -am -DskipTests -Dfast packageAPI and Format
This renames internal Java APIs for remote segment physical start offsets. It does not change the RPC wire format, manifest storage format, or remote log end-offset semantics.
Documentation
No user-facing documentation changes are required.
Generative AI disclosure