Addded try catch block for Pre, Post processors.#6735
Open
rajat315315 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #6734
Description
runPostProcessors(...)inorg.apache.jmeter.threads.JMeterThread:ex.process()calls intry-catch (Exception | JMeterError e)blocks.runPreProcessors(...)inorg.apache.jmeter.threads.JMeterThread:ex.process()calls intry-catch (Exception | JMeterError e)blocks to ensure pre-processor failures do not interrupt subsequent pre-processors or sample sampling.org.apache.jmeter.threads.TestJMeterThread:testPostProcessorExceptionHandling(): Verifies that when a PostProcessor throws an exception, remaining PostProcessors and sample pipeline steps continue executing.testPreProcessorExceptionHandling(): Verifies that when a PreProcessor throws an exception, remaining PreProcessors and the main sampler execute cleanly.Motivation and Context
Resolves an issue where an uncaught
RuntimeExceptionin aPreProcessororPostProcessorwould abort the execution loop, preventing subsequent processors from running and skipping sample assertions, listener notifications, and compiler state cleanup.How Has This Been Tested?
Ran Gradle test suite for core module:
./gradlew :src:core:test --tests "org.apache.jmeter.threads.TestJMeterThread"Types of changes
Checklist: