[KYUUBI #7674] Fix flaky PyHive SQLAlchemy insert tests - #7675
Open
wForget wants to merge 1 commit into
Open
Conversation
pan3793
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
The Python test suite runs with multiple pytest-xdist workers.
test_insert_selectandtest_insert_valuesused the samepyhive_test_database.insert_testtable, and both tests dropped and recreated it.When the tests ran concurrently, one test could drop the table while the other was inserting or querying data, causing intermittent
table not foundfailures.This patch assigns a dedicated table name to each test to prevent the collision.
Closes #7674.
How was this patch tested?
Existing test cases.
Was this patch assisted by generative AI tooling?
Assisted-by: OpenAI Codex (GPT-5)