[KYUUBI-7659][INFRA] Restore code coverage by not overriding the test argLine - #7683
Closed
zhang-arvin wants to merge 1 commit into
Closed
[KYUUBI-7659][INFRA] Restore code coverage by not overriding the test argLine#7683zhang-arvin wants to merge 1 commit into
zhang-arvin wants to merge 1 commit into
Conversation
Contributor
|
I am closing [PR 7680](#7680) and [PR 7681](#7681) because the proposed fixes are not suitable in their current form. [PR 7682](#7682) duplicates the approved [PR 7669](#7669), and [PR 7683](#7683) duplicates the active [PR 7661](#7661). Please check for existing work and coordinate with other contributors before opening a PR. Also follow the PR template and include test results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
-Pcodecovhasn't produced any coverage since 1.8.0 because bothmaven-surefire-pluginandscalatest-maven-pluginoverride theirargLinewith${extraJavaTestArgs}, which drops the JaCoCo agent thatjacoco:prepare-agentpublishes to the${argLine}property.This PR moves the JDK
--add-opensoptions into theargLineproperty itself (referencingextraJavaTestArgs) and removes theargLineoverrides from both plugin configs. This allowsjacoco:prepare-agentto prepend its agent to the property's existing value.How was this patch tested?
Manual verification:
Should produce
target/jacoco.execand a coverage report.Closes #7659