refactor(desktop): separate shared sessions from Runtime Host profiles - #4273
Merged
Conversation
6 tasks
M4n5ter
force-pushed
the
refactor/session-guest-mounts
branch
3 times, most recently
from
August 31, 2026 00:51
0b89078 to
53dcae6
Compare
jackwener
approved these changes
Aug 31, 2026
jackwener
left a comment
jackwener
left a comment
Member
There was a problem hiding this comment.
Approved at the explicit direction of M4n5ter. No technical review was performed as part of this action; M4n5ter requested the approval and accepts responsibility for subsequent handling.
Review notice: This approval was submitted by an automated review agent operated by jackwener and is published at the direction of M4n5ter, who is the human accountable for it.
M4n5ter
force-pushed
the
refactor/session-guest-mounts
branch
2 times, most recently
from
August 31, 2026 04:09
c2d8c93 to
cd9d0e6
Compare
Generated-by: OpenAI Codex
Generated-by: OpenAI Codex
github-actions
Bot
added
effort/XL
M4n5ter
force-pushed
the
refactor/session-guest-mounts
branch
2 times, most recently
from
August 31, 2026 05:50
d794749 to
2a845ff
Compare
M4n5ter
force-pushed
the
refactor/session-guest-mounts
branch
from
August 31, 2026 06:02
2a845ff to
0444e5f
Compare
M4n5ter
marked this pull request as ready for review
August 31, 2026 06:10
saltand
pushed a commit
to saltand/maka-agent
that referenced
this pull request
Aug 31, 2026
apache#4273) * refactor(desktop): separate shared sessions from Runtime Host profiles Generated-by: OpenAI Codex * fix(desktop): preserve guest authority settlement * fix(desktop): complete Runtime Host identity projection Generated-by: OpenAI Codex * fix(desktop): retire sessions by Host profile identity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
English
Separate shared-Session Guest connections from normal Runtime Host profiles. A collaboration invitation now creates a bounded, credential-backed Guest mount with its own reconnect and removal lifecycle, so it cannot alter default-Host preferences or leave pairing recovery state behind.
This is the first PR in the Runtime Host connectivity lifecycle stack.
中文
将共享 Session 的 Guest 连接从普通 Runtime Host profile 中分离。协作邀请现在创建独立、数量受限且由凭据存储支撑的 Guest mount，并拥有自己的重连和移除生命周期，因此不会修改默认 Host 偏好，也不会遗留配对恢复状态。
这是 Runtime Host 连接生命周期重做 stack 的第一个 PR。
Refs #3843
Verification
English
中文
Review focus
Guest credentials and Session authority remain resource-scoped; this path must never re-enter normal profile preferences, pairing journals, or default-Host selection.
AI use
Tool(s) and scope: OpenAI Codex — architecture planning, implementation, focused tests, and review.
Checklist
Does this PR entail a change in behavior?