Revert "GH-3574: Statistics.toParquetStatistics always set null_count (#3575)" - #3688
Merged
Conversation
…_count(apache#3575)" This reverts commit 63aebcc.
kevinjqliu
approved these changes
Jul 26, 2026
kevinjqliu
left a comment
kevinjqliu
left a comment
Contributor
There was a problem hiding this comment.
LGTM
The change is valid based on parquet-format, which recommends writing null_count even when it’s zero, but it doesn’t preserve backward compatibility and can cause problems for downstream consumers like Iceberg.
We should revert for now until we find a safer way to introduce this change.
wgtmac
approved these changes
Jul 27, 2026
wgtmac
left a comment
wgtmac
left a comment
Member
There was a problem hiding this comment.
I agree we need to revert that PR to unblock the release. But I do think that fix is valid in essence.
Contributor
|
lets reopen #3574 to track this |
Contributor
Author
|
I've re-opened the issue, and I agree @wgtmac, the change on its own makes sense, but currently we implicitly have either all the stats, or no stats at all. So we should evolve that contract 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 63aebcc.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?