Log the classic hostname verification warning at warning level - #3479
Merged
Conversation
### Motivation Both remoting transports log when TLS is enabled without hostname verification, but at different levels. Artery logs at `warning`, classic remoting at `info`, where it is easily lost in startup output. Both carry the `LogMarker.Security` marker, which the documentation tells operators to treat as security relevant, so the lower level in classic understates it. ### Modification Log the classic remoting message at `warning`, matching artery. The message text is unchanged, as is the `LogMarker.Security` marker. ### Result Both transports report a disabled hostname verification at the same level. ### Tests No test asserts on this message or its level. ### References None - noticed while reviewing apache#3478
pjfanning
requested review from
He-Pin,
Philippus,
nvollmar,
raboof and
samueleresca
August 27, 2026 16:25
samueleresca
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Both remoting transports log when TLS is enabled but hostname verification is
disabled, and both mark the message with
LogMarker.Security. They disagree onthe level:
artery/tcp/ConfigSSLEngineProvider.scala)warningtransport/netty/SSLEngineProvider.scala)infoLogMarker.Securityis the marker the documentation tells operators to treat assecurity relevant, so logging it at
infoin classic remoting understates itand makes it easy to lose in startup output.
Modification
Log the classic remoting message at
warning, matching artery. The message textand the
LogMarker.Securitymarker are unchanged, and the artery side isuntouched.
Result
Both transports report a disabled hostname verification at the same level.
Tests
remote/Compile/compilepasses. No test asserts on this message or its level.References
None - noticed while reviewing #3478