[FIX][Testing] Strip whitespace when parsing testing env flags#20045
Open
Charmve wants to merge 1 commit into
Open
[FIX][Testing] Strip whitespace when parsing testing env flags#20045Charmve wants to merge 1 commit into
Charmve wants to merge 1 commit into
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SKIP_SLOW_TESTS,WHEEL_TEST, andCIintvm.testing.utils._env_truthy()helper used by slow-test and wheel-test skips.Motivation
CI/K8s env values are often exported with accidental whitespace, which silently disables or mis-parses flags.
Test plan
tests/python/testing/test_testing_utils_env.py