fix(logging): Preserve host application logging configuration#2010
Open
vdusek wants to merge 3 commits into
Open
fix(logging): Preserve host application logging configuration#2010vdusek wants to merge 3 commits into
vdusek wants to merge 3 commits into
Conversation
…x adaptive-crawler extra
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2010 +/- ##
==========================================
- Coverage 93.35% 93.35% -0.01%
==========================================
Files 179 179
Lines 12482 12497 +15
==========================================
+ Hits 11652 11666 +14
- Misses 830 831 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
BasicCrawler.__init__(with the defaultconfigure_logging=True) calledconfigure_logger(root_logger, remove_old_handlers=True), wiping the host application's root logging handlers. Embedding Crawlee in a larger app silently removed the host's own logging configuration.Changes
logging.basicConfigsemantics. A host that has already configured logging keeps its configuration.httpxlogger silencing was moved out ofBasicCrawlerintoHttpxHttpClient. It used to live unconditionally in the base crawler, even though the default HTTP client (ImpitHttpClient) doesn't use thehttpxlogger at all, and it reached into a third-party logger straight from the base class. The silencing now applies only whenHttpxHttpClientis actually instantiated, which is where the noisy per-requesthttpxINFO logs originate.Verification
Regression tests that fail without the fix:
HttpxHttpClientsilences thehttpxlogger toWARNINGby default.Behavior change
This intentionally changes observable behavior, since the old behavior was the bug: host apps keep their logging config.
For
HttpxHttpClientusers, thehttpxlogger is now silenced whenever the client is instantiated. Previously the silencing happened only duringBasicCrawlerconstruction, withconfigure_logging=Trueand an unconfigured root logger. As a result it now also applies withconfigure_logging=Falseand to standalonesend_requestusage.