docs: Fix stale and inaccurate documentation#2081
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2081 +/- ##
=======================================
Coverage 93.47% 93.48%
=======================================
Files 181 181
Lines 12552 12552
=======================================
+ Hits 11733 11734 +1
+ Misses 819 818 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vdusek
marked this pull request as ready for review
July 21, 2026 06:29
Pijukatel
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes four documentation inaccuracies surfaced by the engineering audit:
README.md—BeautifulSoupCrawlerno longer defaults toHttpxHttpClient. Updated the stated default toImpitHttpClient, matchingBasicCrawler.Dataset.push_data— the docstring claimed a hard 9MB per-object limit, but no local storage client enforces any size limit. Clarified that local clients impose no limit and the 9MB per-object cap applies only to remote clients such as the Apify platform.EnqueueLinksKwargs.strategy— the docstring described only link extraction (enqueue_links), but the field is inherited byadd_requests, which filters explicitly provided requests. Reworded to cover both, and corrected the default note (same-hostnameis the default forenqueue_links).max_requests_per_crawl=10but the prose said "after the 20th request". Fixed to "10th".Docstring and prose only, no behavior change.
✍️ Drafted by Claude Code