Fix misleading build.log warning, add flag to suppress it, update to node24 - #5
Merged
Merged
Conversation
build.log is optional: without it the deploy still succeeds, build data just won't be viewable in the AppPack dashboard. Reword the warning to say so instead of claiming the deploy will fail, and add a suppress-build-log-warning input (default false) to silence it for builds that intentionally don't produce a build.log. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
node16 is deprecated on GitHub Actions runners. Bump .tool-versions to the current v24 LTS to match. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Member
|
Released as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We recently switched our image build to
docker/build-push-actionfor improved caching performance in GHA, which means we no longer produce abuild.log. Deploys work fine without it, but every deploy now emits this warning:That message isn't accurate -- the deploy succeeds without it, and the README already documents
build.logas optional. The only real consequence is that build data won't be viewable in the AppPack dashboard.Changes:
build.logwarning to say it's safe to ignore and only affects dashboard build data visibility. Other missing artifacts keep the original message.suppress-build-log-warninginput (defaultfalse) for builds that intentionally don't produce abuild.log.node16tonode24(and.tool-versionsto match).Here's what we see on every deploy:
