ci: standardise pre-commit, lint and release tooling - #18
Open
av-dev2 wants to merge 22 commits into
Open
Conversation
…e-fines-queue fix(vehicle-sync): defer failed retries until pending queue is processed
Added comprehensive specification document for CSF TZ application, outlining goals, application model, functional domains, extension model, integration model, and development rules.
…t-tooling chore: enforce app-owned ruff, pre-commit and frappe semgrep hooks
…-scan ci: run frappe semgrep as a full-repo scan instead of inside pre-commit
…-install-job ci: drop bench install job, tests run manually on the bench
…-dependency fix: drop unused PyPDF2 dependency flagged by pip-audit
…ation/bootstrap-frappe-maintenance-version-15-hotfix chore: add Frappe maintenance workflow
…-specfile chore: Add CSF TZ specification document
style: apply ruff format and fix all pre-commit findings
(cherry picked from commit 3ca3fc5)
(cherry picked from commit a25700f)
…-hotfix fix(settings): remove duplicate authority notification field migration
…ort-429-to-version-15-hotfix [Backport version-15-hotfix] fix: avoid monkey patch loading during site-less builds
…ort-431-to-version-15-hotfix [Backport version-15-hotfix] fix: add dedicated group for multicurrency bank charges
Add a pre-push hook that runs pre-commit over the whole repository, so a push is rejected when any file is unclean. The commit hook keeps checking staged files only. Replace the divergent per-app setups with one shared toolchain: ruff for lint and format, the self-contained frappe-semgrep hook, and commitlint for commit messages. Anchor the exclude regex so .github/ is no longer skipped by an unanchored .git pattern. Add the pre-commit and semantic-commits workflows, and scripts/setup-git-hooks.sh for a one-command developer bootstrap. Remove ci.yml. Building a bench and migrating a throwaway site cost five to eight minutes per pull request and went red for upstream and runner problems unrelated to the change. Frappe tests continue to run locally. Remove release.yml and .releaserc.json. tag-and-promote-from-pr-label.yml is now the only owner of tags, releases and promotion; running semantic-release alongside it made both tag the same version at different commits.
Mechanical reformat produced by the standardised hooks. No behaviour change.
claim_batch wrote WORKER_ID into the claimed_by field but the name was never defined, so every claim raised NameError. The surrounding except swallowed it, leaving the queue silently doing nothing. claimed_by is a plain Data field, so a host and process identifier fits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.