Conversation
narahavi
marked this pull request as ready for review
July 14, 2026 17:50
Implements single-file Upload and Download for the SEP-compliant S3 Transfer Manager (aws-cpp-sdk-s3-transfer), backed by aws-c-s3 meta requests via the aws-crt-cpp S3 bindings. Covers file and stream sources/sinks, progress and finish callbacks, checksum config, cancellation, and CRT-to-SEP error mapping.
sbaluja
reviewed
Jul 16, 2026
sbaluja
reviewed
Jul 16, 2026
sbaluja
reviewed
Jul 16, 2026
sbaluja
reviewed
Jul 16, 2026
sbaluja
reviewed
Jul 16, 2026
sbaluja
reviewed
Jul 16, 2026
sbaluja
reviewed
Jul 16, 2026
sbaluja
reviewed
Jul 16, 2026
sbaluja
reviewed
Jul 16, 2026
sbaluja
reviewed
Jul 16, 2026
sbaluja
reviewed
Jul 16, 2026
sbiscigl
reviewed
Jul 20, 2026
sbaluja
reviewed
Jul 28, 2026
Collaborator
There was a problem hiding this comment.
Is it fine that we are leaving credentialsProvider uninitialized in this path? Would like to see this path tested in the integ tests, ie constructing with a provided client
sbaluja
reviewed
Jul 28, 2026
Collaborator
There was a problem hiding this comment.
This is what i was alluding to when talking about the m_credentialsProvider being null, because now we're passing it down to this function
sbaluja
reviewed
Jul 28, 2026
Collaborator
There was a problem hiding this comment.
Is this comment true? Is it ordered?
sbaluja
reviewed
Jul 28, 2026
Collaborator
There was a problem hiding this comment.
One thing I wanna say is both dispatch download/upload are massive functions, is there functionality we can split into helpers?
sbaluja
reviewed
Jul 28, 2026
Collaborator
There was a problem hiding this comment.
Here is where we should probably pass the underlying impl pointer instead of moving the entire request object. Same for download
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Single File Upload/Download for TM 2.0
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.