Add Smithy operation model translation to codegen - #7233
Open
Fred1155 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR adds the operation layer for smithy codegen migration. It's the Smithy-side counterpart to AddOperations (plus the empty input/output handling that C2J splits into AddEmptyInputShape/AddEmptyOutputShape). The goal is given the same API, produce the same OperationModels the C2J path produces. It's not wired into the generator yet and that happens in a later PR that adds the builder.
Modifications
Add AddSmithyOperations, which walks the operations reachable from a Smithy service and fills in one OperationModel each: name, protocol, deprecation, documentation, input/output types (including Unit synthesis), payload flags, exceptions, endpoint discovery, endpoint host prefix, checksums, request compression, context params, unsigned payload, and auth.
Add a ProtocolUtils.resolveProtocol(ServiceIndex, ServiceShape) overload that maps a service's applied Smithy protocol traits to the SDK protocol string, reusing the existing priority list so multi-protocol services (e.g. awsQuery + awsJson1_0) resolve the same way the C2J path resolves them.
Pagination (isPaginated) is intentionally left unset here; it depends on paginator data that a later PR adds.
Testing
AddSmithyOperationsTest and ProtocolUtilsTest covers the new overload including the multi-protocol case and the unsupported-protocol error.
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License