fix: filter full recipe template from serverless train( )#6021
Merged
mujtaba1747 merged 9 commits intoJul 14, 2026
Conversation
jam-jee
reviewed
Jul 14, 2026
| def _apply_recipe_to_hyperparameters( | ||
| self, | ||
| final_hyperparameters: Dict[str, Any], | ||
| only_user_overrides: bool = False, |
Collaborator
There was a problem hiding this comment.
nit: can be renamed to is_serverless or something like this to improve readability.
Collaborator
Author
There was a problem hiding this comment.
Agreed, will re-use Compute param.
Collaborator
|
Do we need to test Nova/Serverful/Hyperpod usecases as well. If not manual can we add tests? |
Collaborator
Author
|
We already have tests for hyperpod. Hyperpod and serverful should not be affected by this change as it's gated by the boolean flag. |
Collaborator
Author
|
Serverful tests are being included as part of Zhaoqi's PR. I'm also doing some serverful testing manually for now. |
jam-jee
previously approved these changes
Jul 14, 2026
zhaoqizqwang
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title: fix: filter full recipe template from serverless train()
Summary
recipe template can contain hundreds of internal leaf keys the user never touched, causing API
validation failures.
only forward keys the user explicitly provided (direct assignments, overrides dict, or recipe
YAML).
full recipe passthrough since it renders into a YAML file with no key-count limit.
Test plan
hyperparameters" when using a large recipe template
paths)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.