fix(docs): drop .mdx suffix from signInWithEthereum link#1739
Open
Kajko25 wants to merge 1 commit into
Open
Conversation
The link in the "Usage with Capabilities" section pointed at /base-account/reference/core/capabilities/signInWithEthereum.mdx, which 404s on the live site. Every other internal link across the repo (415 of them, including two others on the same target page, capabilities/overview.mdx) omits the .mdx suffix -- this was the only one that had it. Closes base#685
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The link in the "Usage with Capabilities" section of
wallet_connect.mdxpoints at/base-account/reference/core/capabilities/signInWithEthereum.mdx, which 404s on the live site — matches issue #685.Checked the rest of the repo: every other internal link (415 of them, including two others on this exact same target page,
capabilities/overview.mdx) omits the.mdxsuffix. This was the only one that had it.Fix: drop the
.mdxsuffix so it matches the working convention used everywhere else.Closes #685