Enable beman-tidy (--require-all mode) into beman.map#4
Open
neatudarius wants to merge 2 commits into
Open
Conversation
Turning on --require-all surfaced two Beman Standard gaps that needed fixing. Moved the beman.map add_library above the beman::optional alias block so the cmake.library_name check sees beman.map as the first target instead of the alias. The alias is still created before target_link_libraries uses it, so the behavior is unchanged. Added the Compiler Explorer badge that release.godbolt_trunk_version requires. The link runs the basic_get example against beman.map and beman.optional on trunk, so it is a real working example rather than a placeholder.
Member
Author
|
Thanks @ssam18! |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: bemanproject/beman-tidy#333