Align BEMAN_OPTIONAL_BUILD_TESTS with Beman Standard#245
Closed
neatudarius wants to merge 1 commit into
Closed
Conversation
neatudarius
commented
Jul 16, 2026
| ) | ||
|
|
||
| if(OPTIONAL_ENABLE_TESTING) | ||
| if(BEMAN_OPTIONAL_BUILD_TESTS) |
Member
Author
There was a problem hiding this comment.
neatudarius
force-pushed
the
cmake/skip-tests-standard-option
branch
from
July 16, 2026 06:38
b97b858 to
eb0da30
Compare
Rename OPTIONAL_ENABLE_TESTING to BEMAN_OPTIONAL_BUILD_TESTS and document how to disable tests in README.
neatudarius
force-pushed
the
cmake/skip-tests-standard-option
branch
from
July 16, 2026 06:39
eb0da30 to
9134e6d
Compare
neatudarius
marked this pull request as ready for review
July 16, 2026 06:41
Member
Author
|
Superseded by #246, which now includes skip_tests, skip_examples, and README Build Environment alignment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to upcoming new beman-tidy new feature: bemanproject/beman-tidy#346. Changes in this library needs to be fixed before releasing new beman-tidy including this feature.
Summary
OPTIONAL_ENABLE_TESTINGtoBEMAN_OPTIONAL_BUILD_TESTS${PROJECT_IS_TOP_LEVEL}defaultSatisfies
cmake.skip_testsfrom beman-tidy.Test plan
beman-tidy—cmake.skip_testspasses locally