Skip to content

[1.4] core: tools: blueos_startup_update: Apply Navigator overlays on Pi5 - #4113

Merged
Williangalvani merged 1 commit into
bluerobotics:1.4-devfrom
joaoantoniocardoso:backports/1.4/support_pi5-1.4
Aug 12, 2026
Merged

[1.4] core: tools: blueos_startup_update: Apply Navigator overlays on Pi5#4113
Williangalvani merged 1 commit into
bluerobotics:1.4-devfrom
joaoantoniocardoso:backports/1.4/support_pi5-1.4

Conversation

@joaoantoniocardoso

@joaoantoniocardoso joaoantoniocardoso commented Aug 10, 2026

Copy link
Copy Markdown
Member

Solves the Pi 5 case in #4111 for 1.4. This will be ported to master in another PR.

  • Tested.

@github-actions

Copy link
Copy Markdown

Automated PR Review

0. Summary

  • Verdict: LGTM :shipit:

Extends update_navigator_overlays() in core/tools/blueos_startup_update/blueos_startup_update.py to also run on Pi5 by branching on get_cpu_type() and picking the Pi5-specific overlay list plus the pi5 section name, and moves the navigator patch into the existing Pi4/Pi5 combined patches_to_apply block in main(). Both overlay lists (Pi4 and Pi5) are verbatim copies of the entries already present in install/boards/bcm_27xx.sh and install/boards/bcm_2712.sh respectively — including the intentional-looking dtoverlay=i2c3-pi5.baudrate=400000 sibling entry mirrored from bcm_2712.sh:57. The else branch logs an error and returns False, matching the same defensive fallback already used in update_dwc2() at line 358.

No further comments, nice job 👍

Generated by PR Review Bot. This is advisory, a human reviewer must still approve.

@joaoantoniocardoso joaoantoniocardoso changed the title core: tools: blueos_startup_update: Apply Navigator overlays on Pi5 [1.4] core: tools: blueos_startup_update: Apply Navigator overlays on Pi5 Aug 11, 2026
@patrickelectric

Copy link
Copy Markdown
Member

just be aware that this release does not need to support pi 5

@joaoantoniocardoso

Copy link
Copy Markdown
Member Author

just be aware that this release does not need to support pi 5

Not officially, but we need the support internally (R&D).

@Williangalvani
Williangalvani merged commit 6b05f54 into bluerobotics:1.4-dev Aug 12, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants