New shifted metric - #1177
Closed
johnomotani wants to merge 4 commits into
Closed
Conversation
johnomotani
force-pushed
the
new_shifted_metric
branch
2 times, most recently
from
July 25, 2018 15:26
17420ea to
ad84a2b
Compare
johnomotani
force-pushed
the
new_shifted_metric
branch
from
October 1, 2018 12:07
17cc854 to
7235402
Compare
johnomotani
changed the base branch from
newfield-nextmerge
to
shiftedmetric-updates
October 1, 2018 12:08
Contributor
Author
|
The |
johnomotani
force-pushed
the
shiftedmetric-updates
branch
from
October 9, 2018 15:07
3e7b005 to
ab43f72
Compare
johnomotani
force-pushed
the
new_shifted_metric
branch
from
October 9, 2018 15:28
7235402 to
2dd1c1d
Compare
This was referenced Oct 10, 2018
johnomotani
force-pushed
the
shiftedmetric-updates
branch
2 times, most recently
from
October 26, 2018 13:05
545aae5 to
79b5157
Compare
Implementation of 'shifted metric' method that works by shifting all fields to field aligned coordinates, instead of calculating yup/ydown fields. This allows staggered grids to be handled.
Gives a basic test of the ShiftToFieldAligned parallel transform class. Also add test-yupdown to the default tests by removing the '#requires all_tests'.
johnomotani
force-pushed
the
new_shifted_metric
branch
from
October 26, 2018 13:51
2dd1c1d to
78d3fe1
Compare
Closed
Contributor
Author
|
Being replaced by #1460. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a ParallelTransform class that shifts variables to a field-aligned coordinate system. This means all shifted variables share the same coordinate system even when they are on staggered grids, so this method is compatible with staggered grids while the existing ShiftedMetric class is not.
Depends on updates from #1060 (hence PR based on #1060) and also #1176 (the number of files touched by this PR should go down quite a bit if #1176 is merged into the base).