Remove mergeYupYdown() - #1287
Closed
johnomotani wants to merge 3 commits into
Closed
Conversation
This was used to set yup/ydown to point to the field itself. Used by ParallelTransformIdentity. It is unnecessary because there are field-aligned versions of all the operators, which can be used when hasYupYdown()==false. Removing the method simplifies several tests, which can now be just 'var.hasYupYdown()' where previously they also had to check 'var.yup() != var' and 'var.ydown() != var'. Also rename 'splitYupYdown()' to 'createYupYdown()' since it no longer makes sense to contrast 'split' with 'merge'.
Allows this method to be used for fields that do not have yup/ydown.
Closed
Member
|
This is backwards incompatible, so probably not going to get in just yet, but plausibly soon. |
Member
|
Presumably if we wish to remove things in the next version we should deprecate them in v4.2 so you may want to explore deprecating this now so that you're able to remove for v4.3? |
johnomotani
added a commit
that referenced
this pull request
Oct 13, 2018
splitYupYdown() is still present, but also deprecated. These are deprecated so we can remove them in v4.3, see PR #1287.
Contributor
Author
|
Closing: see discussion in #1321. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Field3D::mergeYupYdown()was used to set yup/ydown to point to the field itself. Was used by ParallelTransformIdentity. It is unnecessary because there are field-aligned versions of all the operators, which can be used when hasYupYdown()==false.Removing the method simplifies several conditionals, which can now be just 'var.hasYupYdown()' where previously they also had to check 'var.yup() != var' and 'var.ydown() != var'.
Also rename 'splitYupYdown()' to 'createYupYdown()' since it no longer makes sense to contrast 'split' with 'merge'.