Remove result_fa from interp_to - #1427
Merged
Merged
Conversation
d7919
reviewed
Dec 10, 2018
| Field3D result_fa(fieldmesh); | ||
| if (region != RGN_NOBNDRY) { | ||
| result_fa = fieldmesh->toFieldAligned(result); | ||
| result = fieldmesh->toFieldAligned(result); |
Member
There was a problem hiding this comment.
Should this be result = var_fa to save duplicate toFieldAligned calls (my understanding is that result=var in this situation)?
Contributor
Author
There was a problem hiding this comment.
You're right 👍 I think the behaviour we are supporting at this point is a bug, but that's a separate issue (#1430).
Remove the intermediate variable result_fa in branch of interp_to that transforms to field-aligned variables. Just store the intermediate result in 'result' instead, to save memory.
johnomotani
force-pushed
the
remove-result_fa-from-interp-to
branch
from
December 10, 2018 15:58
f05a293 to
1d3f032
Compare
Closed
d7919
approved these changes
Dec 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the intermediate variable result_fa in branch of interp_to that transforms to field-aligned variables. Just store the intermediate result in 'result' instead, to save memory.
This commit was previously part of #1176, but isn't really related and it looks like #1176 won't be merged (at least in its current form).