Separate initialization of ParallelTransform objects from constructors - #1463
Closed
johnomotani wants to merge 1 commit into
Closed
Separate initialization of ParallelTransform objects from constructors#1463johnomotani wants to merge 1 commit into
johnomotani wants to merge 1 commit into
Conversation
Allows localmesh->getCoordinateSystem() to call ParallelTransform::getCoordinateSystem() during initialization of the ParallelTransform.
johnomotani
added
work in progress
Contributor
Author
|
Updates to #1459 removed the need for this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows
localmesh->getCoordinateSystem()to callParallelTransform::getCoordinateSystem()during initialization of theParallelTransform.Something like this would be nice to have to ensure that all
Field3Ds get the rightcoordinate_systemset, instead of ever havingCOORDINATE_SYSTEM::None, but probably makes more sense to include something like it as part of refactoringParallelTransform(e.g. makingParallelTransforma member ofCoordinatesrather thanMesh).See discussion in #1459.