Nested arrays for simple slicing - #1505
Open
d7919 wants to merge 9 commits into
Open
Conversation
Could be dangerous but mirrors standard containers
Adds/expands on mechanisms to check and enforce unique nature
shape/size methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is mostly just for discussion -- it provides a sample implementation of a multi-dimensional container that supports simple slicing. It's ultimately backed by
Array.It's probably not very efficient currently.
It's missing unit tests.
Here's an ugly example of how it could be (ab)used
This could be useful for the inversion code where we deal with matrices/tensors and want to get the contiguous z-slices out of this data -- with
ArrayNDwe can get these asArrays without any copying.