Enable FPE checking by default - #1538
Closed
dschwoerer wants to merge 1 commit into
Closed
Conversation
Member
|
What's the overhead of signalling FP? I don't think it's free, but maybe it's sufficiently cheap on modern processors. |
Contributor
Author
|
I thought that there should be no impact, but I failed to find a source. I wrote a small test, and I could find no significant bias, whether disabling or enabling is faster. This still needs work, as parts of the field may not be set, (due to the region flag) and that may cause issues ... I will close this, until I have a patch ... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As some checks get disabled in #1533 - it may be beneficially to catch floating point exceptions in a different way.
This enables by default SIG_FPE - if the required fenv header is available.