cjson: skip nested-intersection-union.schema (invalid-type inputs are not checked)#2
Merged
Ankur Goyal (ankrgyl) merged 1 commit intoJul 13, 2026
Conversation
…e not checked (known limitation) cjson's generated parser does not validate invalid types in unions, maps, and arrays (documented above this skip list), so it silently coerces the fixture's expected-failure instance (array where an object is required) into an empty object instead of rejecting it. Skip the schema for cjson, exactly like the existing class-with-additional, go-schema-pattern-properties, and multi-type-enum skips. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
nested-intersection-union.schemato cjson'sskipSchemalist — one line intest/languages.ts.Why
The only genuine CI failure on the current
intersection-fixhead iscjson,schema-cjson(the other red jobs are fail-fast cancellations). The new fixture's expected-failure instance (nested-intersection-union.1.fail.union.json, an array where an object is required) is silently coerced to{}by cjson's generated parser instead of being rejected, so the harness's "this input must fail" assertion trips.This is cjson's documented limitation, quoted from the comment above its skip list:
Every other schema with a
.fail.union.jsonnegative (class-with-additional.schema,go-schema-pattern-properties.schema,multi-type-enum.schema) is already skip-listed for cjson for exactly this reason; this fixture gets the same treatment.Merging this into
intersection-fixupdates glideapps#2914. Note the fail-fast cancellations mean several languages haven't run the new fixture yet — the next full CI run is the real arbiter.🤖 Generated with Claude Code