BRE2-987: Use SSH Access instead of Public DNS for 'brev shell'#424
Merged
Conversation
drewmalin
commented
Jul 22, 2026
Comment on lines
174
to
190
| @@ -186,7 +183,6 @@ func getExternalNodeSSHEntries(store RefreshStore) []ssh.ExternalNodeSSHEntry { | |||
| OrganizationId: org.ID, | |||
| })) | |||
| if err != nil { | |||
| log.Printf("external nodes: skipping (list failed): %v", err) | |||
| return nil | |||
Contributor
Author
There was a problem hiding this comment.
These logs are very noisy and do not actually signal anything useful to the user.
drewmalin
commented
Jul 22, 2026
Comment on lines
115
to
+137
| @@ -132,6 +134,7 @@ func runShellCommand(t *terminal.Terminal, sstore ShellStore, workspaceNameOrID | |||
| if err != nil { | |||
| return breverrors.WrapAndTrace(err) | |||
| } | |||
| printResolvedSSHTarget(sshName) | |||
Contributor
Author
There was a problem hiding this comment.
This is intentional as it is typically confusing as to how the CLI is attempting to connect to the environment.
patelspratik
approved these changes
Jul 22, 2026
drewmalin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now we use the public dns/hostname for ssh config entries. This is almost correct, but it bypasses the more granular ssh_access entries that can be used to directly identify linux username, skybridge FQDN, and port number.
This change attempts to use those entries when refreshing ssh configs, falling back to the public dns/host information for container-mode host, but also in the event of missing network info.