fix(auth): remove Kubernetes service account token fallback#427
Merged
patelspratik merged 1 commit intoJul 24, 2026
Merged
Conversation
patelspratik
approved these changes
Jul 24, 2026
Contributor
|
can we make sure to update any agent skills and/or documentation that mentions this behavior? |
Contributor
Author
Hi @patelspratik , Thanks for flagging this. I checked all relevant documentation and agent skills for anything that documents or depends on the Kubernetes service-account authentication behavior, but I didn’t find any references to or uses of the removed paths. Could you please let me know if there’s anything I may have missed? |
patelspratik
deleted the
BREV-11127/remove-k8s-service-account-token-check
branch
July 24, 2026 22:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Investigation Summary
The authentication flow checked for a Kubernetes service-account token before reading $HOME/.brev/credentials.json.
Fix
Relevant Ticket: https://linear.app/nvidia/issue/BREV-11127/brev-cli-incorrectly-prioritizes-kubernetes-serviceaccount-token-over