fix(cli): omit undefined screenshot options - #2528
Closed
shrey150 wants to merge 8 commits into
Closed
Conversation
🦋 Changeset detectedLatest commit: 651e091 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
shrey150
force-pushed
the
v4-spike-cli-page-runtime
branch
from
August 6, 2026 08:22
db7b4ca to
f2cd89a
Compare
shrey150
force-pushed
the
v4-spike-cli-page-runtime
branch
2 times, most recently
from
August 6, 2026 08:33
ed70a54 to
7d6d774
Compare
shrey150
force-pushed
the
v4-spike-cli-page-runtime
branch
from
August 6, 2026 08:52
7d6d774 to
93a737f
Compare
shrey150
force-pushed
the
v4-spike-cli-page-runtime
branch
from
August 6, 2026 09:03
93a737f to
68e422a
Compare
shrey150
force-pushed
the
v4-spike-cli-page-runtime
branch
from
August 6, 2026 09:08
68e422a to
70c1432
Compare
shrey150
force-pushed
the
v4-spike-cli-page-runtime
branch
from
August 6, 2026 17:37
70c1432 to
7b7d82f
Compare
shrey150
force-pushed
the
v4-spike-cli-page-runtime
branch
from
August 7, 2026 18:43
7b7d82f to
4b2080c
Compare
Contributor
Author
|
Superseded by #2834. The screenshot adapter there omits undefined options when building the V4 screenshot request, so the compatibility fix is folded into the runtime migration where it is exercised by the CLI tests. Closing this draft. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
undefinedvalues onto the V4 wireRefreshed on 2026-08-10 against the current parent and
v4-spikecommitd7556e9a.E2E Test Matrix
pnpm buildpassed 6/6 tasks;pnpm checkpassed 11/11 tasks with 0 errors; the fullpnpm testgraph exited 0, including 17/17 protocol browser tests and 15/15 local SDK browser testsv4-spiked7556e9aacross build, static checks, unit tests, and real-browser suites.example.com, produced a snapshot, clicked through to IANA, filled an injected input, and read backpublished-v4-okcorepack pnpm --dir packages/cli exec vitest run tests/driver-commands.test.tscorepack pnpm --filter browse test:unitscreenshot --base64page-info/screenshotIncludes a
browsepatch changeset for the default screenshot fix.Final release validation (2026-08-10)
At the cumulative stack tip:
browsechangesetsbrowse0.9.7, Stagehand 4.0.1, extension 1.0.1, and Go 4.0.1workspace:*to exact Stagehand 4.0.1