Fix job unblock data precedence - #927
Open
nobradov1c wants to merge 7 commits into
Open
Conversation
nobradov1c
force-pushed
the
nobradovic/fix-unblock-data-precedence
branch
from
August 7, 2026 13:45
e075178 to
8c68a8d
Compare
nobradov1c
marked this pull request as ready for review
August 7, 2026 14:12
Author
|
Cleaned up the PR, sorry for the delay. |
nobradov1c
force-pushed
the
nobradovic/fix-unblock-data-precedence
branch
from
August 14, 2026 14:40
7e1b271 to
fe5f7c4
Compare
|
Thanks a lot! I believe this should be all good now. The status check would likely be resolved if you update the branch by merging main to this branch. |
Author
Updated, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--datavalue over stdin inbk job unblock--datais absent--dataprecedence, stdin fallback, and no-input behaviorFixes #926.
Testing
go test -race ./cmd/jobgo vet ./cmd/jobgit diff --checkI also ran
go test ./...; all relevant packages passed, but the existing keyring tests failed because this development environment has an active shared-memory credential store.