fix: preserve tsconfig jsx emit in babel builds#949
Draft
wanxiankai wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #678.
Preserves JSX during Bob's Babel builds when the project
tsconfig.jsonsetscompilerOptions.jsxtopreserveorreact-native.Why
Libraries that rely on preserved JSX, for example to use a custom
jsxImportSource, currently get their TSX output transformed through@babel/preset-reactanyway. That turns JSX intoreact/jsx-runtimecalls even when TypeScript config asks to keep JSX syntax.What changed
tsconfig.jsonwith TypeScript's config parser during Babel compilation.preserveJSXcaller flag to Bob's Babel preset when JSX emit ispreserveorreact-native.@babel/preset-reactin that mode so@babel/preset-typescriptcan strip types while leaving JSX intact.jsx: "preserve"andjsx: "react-native".Test plan
YARN_GLOBAL_FOLDER=/tmp/codex-yarn-global-builder-bob yarn workspace react-native-builder-bob testYARN_GLOBAL_FOLDER=/tmp/codex-yarn-global-builder-bob yarn lintYARN_GLOBAL_FOLDER=/tmp/codex-yarn-global-builder-bob yarn typecheckYARN_GLOBAL_FOLDER=/tmp/codex-yarn-global-builder-bob yarn workspace react-native-builder-bob preparegit diff --check