fix: bound harness CLI processes - #181
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this?
Harness now bounds direct CLI children and exits cleanly when a run is cancelled while the iOS runner is still starting.
How does it work?
Finite devicectl work observes both a native deadline and a SIGKILL-backed Node deadline. Long-running processes use idempotent disposal that waits for child exit while observing expected cancellation failures. XCTest readiness polling now observes the session abort, and Metro is disposed if a sibling startup task fails.
Why is this useful?
Cancelling a run—before or after the runner is ready—returns a stable failure exit code without leaving Harness-owned child processes or Metro listeners running.