Add predicate queued to taskRun to indicate that task is planned to be started in future - #317
Conversation
0747fcb to
8600499
Compare
498697b to
b45a092
Compare
|
Validated JSONs locally: |
b45a092 to
c080e11
Compare
Signed-off-by: vyuhimenko <vyuhimenko@bloomberg.net> Signed-off-by: vyuhimenko <valentin.yukhymenko@gmail.com>
Signed-off-by: vyuhimenko <vyuhimenko@bloomberg.net> Signed-off-by: vyuhimenko <valentin.yukhymenko@gmail.com>
Signed-off-by: vyuhimenko <vyuhimenko@bloomberg.net> Signed-off-by: vyuhimenko <valentin.yukhymenko@gmail.com>
Signed-off-by: vyuhimenko <vyuhimenko@bloomberg.net> Signed-off-by: vyuhimenko <valentin.yukhymenko@gmail.com>
Signed-off-by: vyuhimenko <vyuhimenko@bloomberg.net> Signed-off-by: vyuhimenko <valentin.yukhymenko@gmail.com>
c080e11 to
e6d2593
Compare
Signed-off-by: Valentyn Yukhymenko <valentin.yukhymenko@gmail.com>
|
@xibz @afrittoli this PR is ready for review, from my perspective. I've fixed all signing issues and last run of CI was green (+ I checked locally). Thank you in advance for your review time :) |
There was a problem hiding this comment.
Pull request overview
This PR extends the Core Events specification by adding a new queued predicate for the taskRun subject, including the associated JSON Schema and a conformance example, and updating the Core Events documentation accordingly (per issue #305).
Changes:
- Added a new JSON Schema for the
taskRun.queuedevent. - Added a
taskRun.queuedconformance example event payload. - Updated
core.mdto listtaskRunas supportingqueuedand to document the new event (and correctedtaskNamedescriptions).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| schemas/taskrunqueued.json | Introduces the JSON Schema for the taskRun.queued event. |
| core.md | Documents the new taskRun.queued predicate/event and updates taskRun predicate listings. |
| conformance/taskrun_queued.json | Adds an example payload for taskRun.queued conformance. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@afrittoli thank you a lot for review! I don't have merge access so please merge this PR if we don't wait for other maintainers. But I am not in rush obviously, just don't know what it the process of merging in this repo :) |
|
@xibz @davidB if you're ok with this, we can squash-merge, unless @BaLiKfromUA prefers to squash and re-push. |
|
I am okay with squash-merge from your side. |
|
@afrittoli no objections from me. Thanks for the PR @BaLiKfromUA! LGTM |
Changes
Closes #305
This PR introduces a new
taskRunpredicate:queued.Consistent with other queued events, this predicate indicates that a task is waiting for the applicable preconditions to be satisfied before it can start running.
This is needed for two reasons:
There is currently a small inconsistency between the predicates available for
taskRunand the kinds of work that a task can represent. ThetestSuiteRunsubject from Testing Events already supports aqueuedpredicate. Since a task can represent a test run, addingqueuedtotaskRunseems consistent with the specification:There is currently no way to express a
taskRunthat has been scheduled for future execution but has not started yet. For example, apipelineRunmay already be started and in progress while one of itstaskRuns is still queued.Note: As of July 2026, there is an ongoing discussion about introducing a separate Scheduler abstraction in CDEvents. Such an addition would not conflict with this PR. In the meantime, the
queuedpredicate can serve as a practical compromise.As an example for making this contribution, I've been using #145
Submitter Checklist
As the author of this PR, please check off the items in this checklist: