feat: add outcome and errors to build.finished - #321
Open
sol-duara wants to merge 1 commit into
Open
Conversation
The build finished section of continuous-integration.md states that the event "will eventually contain the finished status, success, error or failure", but no such field was ever added to the schema. Because subject.content sets additionalProperties: false, producers currently have no conforming way to report whether a build succeeded. Every other event representing the completion of an execution - pipelinerun.finished, taskrun.finished, testcaserun.finished and testsuiterun.finished - already defines outcome with the enum success, failure, cancel, error. build.finished was the only one without it. This mirrors pipelinerun.finished exactly, adding both outcome and errors. Neither is added to required, so the change is backward compatible: events that omit outcome continue to validate. Adding fields is a structural, backward compatible change, so the event version is bumped to a new minor draft (0.3.0 -> 0.4.0-draft) per the versioning policy, using tools/event-version.sh -u build.finished -s. Revives cdevents#179, which made the same change but was closed for staleness after a rebase request rather than on merit. Relates to cdevents#109. Signed-off-by: Dadisi Sanyika <dadisi@solduara.com>
sol-duara
force-pushed
the
feat/build-finished-outcome
branch
from
July 29, 2026 18:02
753a453 to
8d75c70
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build finished section of continuous-integration.md states that the event "will eventually contain the finished status, success, error or failure", but no such field was ever added to the schema. Because subject.content sets additionalProperties: false, producers currently have no conforming way to report whether a build succeeded.
Every other event representing the completion of an execution - pipelinerun.finished, taskrun.finished, testcaserun.finished and testsuiterun.finished - already defines outcome with the enum success, failure, cancel, error. build.finished was the only one without it.
This mirrors pipelinerun.finished exactly, adding both outcome and errors. Neither is added to required, so the change is backward compatible: events that omit outcome continue to validate.
Revives #179, which made the same change but was closed for staleness after a rebase request rather than on merit. Relates to #109.
Changes
Submitter Checklist
As the author of this PR, please check off the items in this checklist: