Updated behaviour of cfengine run-command#179
Merged
Conversation
Now checks if policy exists on remote host or locally. Transfers file as needed from local -> remote, and prompts the user if there is any ambiguity. Ticket: None Changelog: None Signed-off-by: Simon Halvorsen <simon.halvorsen@northern.tech>
olehermanse
approved these changes
Jul 16, 2026
olehermanse
left a comment
olehermanse
left a comment
Member
There was a problem hiding this comment.
Nice improvement! I think ideally we want to use the local one if it exists, and upload it, run it and rm it. I don't think overwriting a policy file with the same name in the home dir is a big deal we need to prevent. I guess with this change it would be copied the first time, and then prompted every time after, which seems a bit annoying.
Being able to run a file already on the remote is a "nice-to-have" but I don't think it will be that important / common.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.