2026 06 25 workflow maintenance 3.24#6193
Open
craigcomstock wants to merge 2 commits into
Open
Conversation
craigcomstock
commented
Jun 25, 2026
craigcomstock
commented
Contributor
- Bump libntech to latest
- Added -Wextra and -Wno-sign-compare to github workflow gcc options
- Refactored variable length array code to use alloca()
Contributor
Author
|
This includes a libntech bump to master. Not sure that is truly needed so that commit could be removed. |
craigcomstock
force-pushed
the
2026-06-25-workflow-maintenance-3.24
branch
from
July 13, 2026 17:27
0af8398 to
09d7005
Compare
Contributor
Author
The bump is needed as libntech has fixes for newer compilers. |
craigcomstock
marked this pull request as ready for review
July 13, 2026 19:53
larsewi
approved these changes
Jul 14, 2026
Ticket: none Changelog: none
This will catch more warnings as errors and help us keep our code cleaner. Ticket: ENT-14208 Changelog: none (cherry picked from commit 7544e66)
craigcomstock
force-pushed
the
2026-06-25-workflow-maintenance-3.24
branch
from
July 15, 2026 18:35
09d7005 to
1b5fc78
Compare
Contributor
Author
|
I see 2 acceptance tests need work here. Will work on them. Strangely both of these tests PASSED elsewhere: https://github.com/cfengine/enterprise/actions/runs/29437361997/job/87429241655 |
olehermanse
requested changes
Jul 17, 2026
olehermanse
left a comment
olehermanse
left a comment
Member
There was a problem hiding this comment.
Changes look good to me, but judging by your comment more work is needed here;
I see 2 acceptance tests need work here. Will work on them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.