Skip to content

CFE-3882: Added strtotime policy function#6237

Open
victormlg wants to merge 1 commit into
cfengine:masterfrom
victormlg:strtotime
Open

CFE-3882: Added strtotime policy function#6237
victormlg wants to merge 1 commit into
cfengine:masterfrom
victormlg:strtotime

Conversation

@victormlg

Copy link
Copy Markdown
Contributor

Merge together with NorthernTechHQ/libntech#284

Changelog: Title
Ticket: CFE-3882
Signed-off-by: Victor Moene <victor.moene@northern.tech>

@larsewi larsewi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some acceptance tests :)

@olehermanse olehermanse left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, as @larsewi said not much to review here, please add acceptance test. Most code review is in libntech.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants