Formatting backports (3.27)#3193
Closed
olehermanse wants to merge 19 commits into
Closed
Conversation
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech> (cherry picked from commit e70dd9f)
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech> (cherry picked from commit 986b015)
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech> (cherry picked from commit e962cb7)
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech> (cherry picked from commit 8f511e2)
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech> (cherry picked from commit 973c812)
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech> (cherry picked from commit 0285fb5)
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech> (cherry picked from commit c271c2c)
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech> (cherry picked from commit e24bf72)
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech> (cherry picked from commit 7c8114c)
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech> (cherry picked from commit 5df6496)
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech> (cherry picked from commit cdbb466)
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
olehermanse
marked this pull request as ready for review
July 13, 2026 21:24
Member
Author
|
@cf-bottom jenkins, please |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/14178/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-14178/ |
nickanderson
approved these changes
Jul 14, 2026
| # Do not do this for cf-hub because cf-hub may have unlimited processes | ||
| # Do not do this for cf-agent because it is not unexpected to have | ||
| # concurrent agent runs, and the lifetime of an individual agent run can be controlled with | ||
| # [agent_expireafter][cf-execd#agent_expireafter] as defined in body executor control |
Member
There was a problem hiding this comment.
These link leftovers from removal of # @ inside bodies and bundles should probably be cleaned up separately.
| "interface_ips" slist => maparray("$(this.k): IPv4 $(this.v)", "sys.ipv4"); | ||
| "interface_info_unsorted" slist => { @(interface_flags), @(interface_ips) }; | ||
| "interface_info" slist => sort(interface_info_unsorted, "lex"); | ||
| # doesn't work :( # "interface_flags" slist => maparray("$(this.k): IP $(sys.ipv4[$(this.k)]), flags $(this.v)", "sys.interface_flags"); |
Member
There was a problem hiding this comment.
Making this.k able to be used in expanding associative array or data container values might be a good one for interns.
Member
Author
|
@cf-bottom try jenkins again, please. |
This was referenced Jul 14, 2026
nickanderson
requested changes
Jul 14, 2026
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/14199/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-14199/ |
Member
Author
|
Superseded by #3195 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.