docs(governance): canon-align service-boundary contract + live verification - #127
docs(governance): canon-align service-boundary contract + live verification#127chitcommit wants to merge 4 commits into
Conversation
…cation - Fix invalid canonical URI/type on the contract (v0.1.0 used the non-canonical `docs/architecture` domain and `type: contract`; both fail live canon validation). Correct to `chittycanon://docs/ops/policy/chittycommand-service-boundary-contract` + `type: policy` (validated clean) and register with the canonical registry. - Overlay a 2026-06-28 live verification: ChittyOS service registry confirms ownership for chittyid/chittyconnect/chittyauth/chittycanon and returns "not found" for chittyrouter (confirms the routing hold). Add `registry_confirmed` to the drift vocabulary; keep repo-file identity drift marked unverified (no repo read access this session). - Log discovered ADR-001 URI drift (same non-canonical domain) without changing it. - Link the contract from CHARTER.md (related docs + discovery_refs) and ADR-001 so it is no longer orphaned. - Add docs/registration/CHITTYID_REMINT_STATUS.md: a status anchor for the live in-repo T->P-Synthetic re-mint (mechanics stay in SUBMISSION_RUNBOOK.md).
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe service-boundary contract advances to v0.2.0 with corrected metadata and live registry findings. CHARTER.md and ADR-001 gain contract references. A new tracker documents the pending ChittyID transition from ChangesService-boundary contract and operational documentation
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This documentation-only change does not introduce runtime or production behavior changes, and no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
To use Codex here, create a Codex account and connect to github. |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
chittycommand | d67e910 | Aug 14 2026, 02:16 PM |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
docs/registration/CHITTYID_REMINT_STATUS.md (1)
58-59: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueClarify operator access controls for this tracker.
The file states "Operator action via the runbook is required" but does not specify who the authorized operator is or how they claim the action. Consider adding a note on which role/identity (e.g.,
chittycommand-operator,chittyid-mint-admin) is authorized to execute the runbook, aligning with the service-boundary contract's ownership and registry_confirmed semantics.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/registration/CHITTYID_REMINT_STATUS.md` around lines 58 - 59, Clarify the operator authorization for this tracker by adding a note near the existing “Operator action via the runbook” statement that names the allowed role/identity and how it is claimed. Update the tracker language to align with the service-boundary contract and registry_confirmed semantics, using the relevant identities such as chittycommand-operator or chittyid-mint-admin so it is clear who may advance the status.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/registration/CHITTYID_REMINT_STATUS.md`:
- Around line 55-56: Update the Service-Boundary Contract row for Person (P,
Synthetic) so it uses the canonical status tag code_confirmed only, and move the
“local, re-mint pending” wording into a separate local note or explanatory
field. Keep the DoD reference aligned with the contract status name in this
markdown section so the status label and local reminder are not combined.
---
Nitpick comments:
In `@docs/registration/CHITTYID_REMINT_STATUS.md`:
- Around line 58-59: Clarify the operator authorization for this tracker by
adding a note near the existing “Operator action via the runbook” statement that
names the allowed role/identity and how it is claimed. Update the tracker
language to align with the service-boundary contract and registry_confirmed
semantics, using the relevant identities such as chittycommand-operator or
chittyid-mint-admin so it is clear who may advance the status.
🪄 Autofix
❌ Autofix failed (check again to retry)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: edec233b-dc99-4d18-b48a-1136d713b266
📒 Files selected for processing (4)
CHARTER.mddocs/architecture/ADR-001-meta-orchestrator-extension.mddocs/architecture/service-boundary-contract.mddocs/registration/CHITTYID_REMINT_STATUS.md
…tion - DoD item 5: reference the canonical `code_confirmed` tag cleanly; move the "re-mint pending" qualifier into an explanatory note (per CodeRabbit). - Add an Authorization section: the re-mint is a sensitive intent (requires_human), authorized to the service owner/operator via the ch1tty->ChittyConnect->chittyid broker, fail-closed if the broker is unavailable. Anchors to real identities (ADR-001 operator, CHARTER ownership) rather than inventing role slugs.
|
|
To use Codex here, create a Codex account and connect to github. |
|
✅ Action performedReview finished.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4d37b6f179
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
… absence Per review (Codex P2): the live-verification text over-claimed the helper_registry_lookup miss as proof routing is absent. ChittyRouter is in fact integrated here (wrangler.jsonc CHITTYROUTER_URL=https://router.chitty.cc) and declared an upstream gateway in CHARTER.md. Reword the ChittyRouter row, the registry-sweep note, and the bottom-line block so the `hold` is scoped to the absence of a canonical routing-ownership record in the registry — not the absence of the service. Aligns with the contract's own anti-overclaiming rule.
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
To use Codex here, create a Codex account and connect to github. |
|
✅ Action performedReview finished.
|
|
Autofix skipped. No unresolved CodeRabbit review comments with fix instructions found. |
There was a problem hiding this comment.
Pull request overview
Docs/governance follow-up that canon-aligns the ChittyCommand service-boundary contract frontmatter (URI/type) and adds a live registry-verification overlay, plus cross-links from ADR-001 and the project charter and a new ChittyID re-mint status tracker.
Changes:
- Updated
docs/architecture/service-boundary-contract.mdfrontmatter to a canon-valid URI/namespace/type and added a “Live verification” evidence layer +registry_confirmedstatus vocabulary. - Linked the canonical service-boundary contract from
CHARTER.mdandADR-001. - Added
docs/registration/CHITTYID_REMINT_STATUS.mdas an operator-facing status anchor for the T → P-Synthetic re-mint.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| docs/registration/CHITTYID_REMINT_STATUS.md | Adds an operator status tracker for the ChittyID T→P-Synthetic re-mint, with DoD and cross-links to the runbook/contract. |
| docs/architecture/service-boundary-contract.md | Canon-aligns URI/type, introduces registry_confirmed, and documents live registry/validator verification results. |
| docs/architecture/ADR-001-meta-orchestrator-extension.md | Adds a “See also” back-reference to the canonical service-boundary contract. |
| CHARTER.md | Adds the canonical service-boundary contract URI to discovery refs and links it in the related-docs triad section. |
Suppressed comments (1)
docs/architecture/service-boundary-contract.md:156
- Section header hard-codes
helper_registry_lookup, but that identifier isn’t defined or referenced elsewhere in this repo. Consider describing the source generically (service registry lookup) to avoid stale docs when tooling names change.
### Service-registry ownership (`helper_registry_lookup`)
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…me last_verified column Per review (Copilot): (1) helper_registry_lookup is not an in-repo symbol — add an interface note identifying it as the external ChittyMCP registry-lookup tool (mcp__ChittyMCP__helper_registry_lookup) and state that the durable claim is the ownership snapshot, not the tool name. (2) Rename the ambiguous last_verified column to registry_last_verified to make clear it is the registry record's own timestamp, distinct from the 2026-06-28 sweep date.
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
To use Codex here, create a Codex account and connect to github. |
|
✅ Action performedReview finished.
|
Follow-up to the merged service-boundary contract (#123), driven by a live status sweep of the canon validator + ChittyOS service registry on 2026-06-28.
What changed
1. Canon-aligned the contract (it didn't validate before)
chittycanon://docs/architecture/chittycommand/service-boundary-contractandtype: contractboth fail live canon validation (architectureisn't a valid docs domain;contractisn't in the frontmatter type enum).chittycanon://docs/ops/policy/chittycommand-service-boundary-contract+type: policy— validated clean and registered with the canonical registry (canon_register_document→registered: true, DRAFT, 2026-06-28T07:08:14Z).2. Live verification overlay (new section) — registry ownership lookups:
chittyidcore/services/identitychittyconnectcore/services/connectchittyauthcore/services/authchittycanoncore/services/canonchittyrouterholdregistry_confirmedto the drift vocabulary (a live evidence layer distinct from repo files).repo_identity_driftclaims (staleCHARTER.md/package.jsonon the other repos) are marked unverified — that check needs read access to those repos, which this session didn't have. They remain flags to confirm, not settled fact.docs/architectureURI domain (left unchanged; flagged for follow-up)./healthdown, aggregator 404) as orthogonal to ownership — so a future reader doesn't mistake it for a boundary change.3. De-orphaned the contract — linked from
CHARTER.md(related docs +discovery_refs) andADR-001(back-reference).4. ChittyID re-mint tracker —
docs/registration/CHITTYID_REMINT_STATUS.md: a single status anchor for the live in-repo T→P-Synthetic re-mint (the one boundary that can reachcode_confirmedwithin this repo). Mint mechanics stay inSUBMISSION_RUNBOOK.md; this only tracks state, blockers, and cross-links.Scope
docs/architecture/service-boundary-contract.md(URI ≠ file path, per CHARTER precedent).Still open (not in this PR)
code_confirmedfor connect/auth/id/router — needs those repos in scope.canonical_drift_blockedcandidate.https://claude.ai/code/session_01886crB52Jw3LWiqPh33WUM
Generated by Claude Code
Summary by CodeRabbit