You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Use the full release tag stored in ARC_VERSION when checking out a release, deriving Docker build metadata, and downloading the Compose configuration.
The version table exposes full tags such as v0.7.3. The current commands prepend another v, producing references such as vv0.7.3, which do not exist.
This complements #199, which updates the version table and arcup example.
Validation
Confirmed refs/tags/v0.7.3 exists; vv0.7.3 does not.
Confirmed the Compose URL for v0.7.3 returns HTTP 200; the doubled-prefix URL returns HTTP 404.
Shallow-cloned v0.7.3 and verified the corrected checkout and revision expressions.
Ran shell syntax validation and git diff --check.
No Docker image build or node bootstrap was run; those operations are not required to validate release-tag interpolation and would introduce unrelated compute and storage work.
Fix is correct and complete. A few verification notes:
Bug is real. The versions table uses v-prefixed tags (v0.6.0, v0.7.3), so ARC_VERSION is set with the prefix included. The four v$ARC_VERSION / v${ARC_VERSION} occurrences in the original all produce vv0.7.3-style strings that don't resolve to any tag, ref, or URL path. Confirmed on the base branch:
No other files in the docs tree contain this pattern — the four changes in this PR are exhaustive.
^{commit} dereference is correct and necessary.v0.7.3 is an annotated tag (the API returns type: tag, not type: commit). The dereference was correct in the original; it's preserved and still correct after the fix.
Inner quoting in the rev-parse subshells is valid bash.$(...) resets the quoting context inside an outer double-quoted string, so "$(git rev-parse "${ARC_VERSION}^{commit}")" is parsed correctly — the inner "${ARC_VERSION}^{commit}" is a double-quoted string inside the command substitution, producing a single argument to git rev-parse. No word-splitting or glob expansion risk.
No conflict with the open PR #199 (different line ranges in installation.md, different content in running-an-arc-node.md).
LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use the full release tag stored in
ARC_VERSIONwhen checking out a release, deriving Docker build metadata, and downloading the Compose configuration.The version table exposes full tags such as
v0.7.3. The current commands prepend anotherv, producing references such asvv0.7.3, which do not exist.This complements #199, which updates the version table and
arcupexample.Validation
refs/tags/v0.7.3exists;vv0.7.3does not.v0.7.3returns HTTP 200; the doubled-prefix URL returns HTTP 404.v0.7.3and verified the corrected checkout and revision expressions.git diff --check.No Docker image build or node bootstrap was run; those operations are not required to validate release-tag interpolation and would introduce unrelated compute and storage work.