Skip to content

feat: add key_usage parameter to certificate variable type - #916

Open
wpt1313 wants to merge 1 commit into
cloudfoundry:masterfrom
wpt1313:feature/add-key-usage-to-variable-types
Open

feat: add key_usage parameter to certificate variable type#916
wpt1313 wants to merge 1 commit into
cloudfoundry:masterfrom
wpt1313:feature/add-key-usage-to-variable-types

Conversation

@wpt1313

@wpt1313 wpt1313 commented Jul 24, 2026

Copy link
Copy Markdown

No description provided.

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: e8d733b3-0073-48c9-b81c-149f6b7a2761

📥 Commits

Reviewing files that changed from the base of the PR and between f8362ff and 554d7c3.

📒 Files selected for processing (1)
  • content/variable-types.md

Walkthrough

Adds documentation for the optional key_usage generation option on the certificate variable type, including supported values, an empty-list default, and an example.

Suggested reviewers: neddp

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided, so there is no content to evaluate. Add a brief description of the change and its intent so reviewers can confirm it matches the PR.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: adding key_usage to the certificate variable type.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-project-automation github-project-automation Bot moved this from Inbox to Pending Merge | Prioritized in Foundational Infrastructure Working Group Jul 24, 2026
@beyhan
beyhan requested review from a team, lnguyen and selzoc and removed request for a team July 30, 2026 14:50
@beyhan beyhan moved this from Pending Merge | Prioritized to Pending Review | Discussion in Foundational Infrastructure Working Group Jul 30, 2026

@a-hassanin a-hassanin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-project-automation github-project-automation Bot moved this from Pending Review | Discussion to Pending Merge | Prioritized in Foundational Infrastructure Working Group Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Pending Merge | Prioritized

Development

Successfully merging this pull request may close these issues.

5 participants