feat: Add support to enable/disable CSP at runtime#10397
Open
patel-vansh wants to merge 2 commits into
Open
Conversation
memleakd
approved these changes
Jul 9, 2026
michalsn
reviewed
Jul 14, 2026
Comment on lines
+91
to
+103
| For example, to enable/disable CSP for a specific response: | ||
|
|
||
| .. literalinclude:: csp/017.php | ||
|
|
||
| The runtime value takes precedence over the ``CSPEnabled`` configuration value | ||
| for the current response. | ||
|
|
||
| These methods only affect the current response. After the response has been sent, | ||
| the CSP instance is recreated and the value of ``CSPEnabled`` in | ||
| **app/Config/App.php** is used as the default for subsequent requests. | ||
|
|
||
| This allows applications to keep CSP enabled globally while temporarily disabling | ||
| it for specific responses, or enable it only where required. |
Member
There was a problem hiding this comment.
CSP is request-scoped, not response-scoped, and the CSP instance is not recreated when the response is sent. I understand the intended meaning, but the current wording does not accurately describe the implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support to let users enable/disable CSP for current request without modifying config variables in runtime.
This lets them exclude specific routes (especially routes handling serving files) from
Content-Security-Policyheader.Checklist: