Handle non-surface Collada geometry - #34
Open
gonzalocasas wants to merge 1 commit into
Open
Conversation
10 tasks
Contributor
|
I am not very familiar with these mesh imports handler, but the fixes look good to me (if it works). |
gonzalocasas
force-pushed
the
dae_import_fixes
branch
from
August 7, 2026 11:59
fb32a9c to
1758784
Compare
There was a problem hiding this comment.
Pull request overview
This PR hardens the COLLADA (.dae) mesh importer to tolerate non-surface/empty geometry nodes (e.g., lines-only or empty meshes) that previously caused imports to abort, and expands material color parsing beyond Phong to additional shader models.
Changes:
- Skip COLLADA geometries that contain no supported surface primitives (triangles/polylist) and only raise an error if the entire file yields no surface meshes.
- Parse material colors from Lambert, Blinn, and Constant shaders in addition to Phong.
- Add a regression test + fixture DAE covering mixed surface, line, and empty geometries with a Lambert diffuse color.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/test_resources.py | Adds regression test asserting non-surface geometry is ignored and Lambert diffuse color is loaded. |
| tests/fixtures/surfaces_lines_and_empty_geometry.dae | New minimal COLLADA fixture containing triangles + lines-only + empty geometry and a Lambert material. |
| src/compas_robots/resources/mesh_importer.py | Updates COLLADA parsing to skip unsupported geometry primitives and broaden shader color extraction. |
| CHANGELOG.md | Documents the importer fix and expanded shader support in Unreleased/Fixed. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UR16e DAE files contained non-surface geo that broke the parsing, added handling for that and also more material support.
What type of change is this?
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.mdfile in theUnreleasedsection under the most fitting heading (e.g.Added,Changed,Removed).invoke test).invoke lint).